Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/iot_authorizer - new resource #14671

Merged
merged 9 commits into from
Sep 28, 2021
Merged

r/iot_authorizer - new resource #14671

merged 9 commits into from
Sep 28, 2021

Conversation

Billlynch
Copy link
Contributor

@Billlynch Billlynch commented Aug 16, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13412

Release note for CHANGELOG:

resource_aws_iot_authorizer - new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIoTAuthorizer'
--- PASS: TestAccAWSIoTAuthorizer_disappears (44.06s)
--- PASS: TestAccAWSIoTAuthorizer_basic (87.09s)

...

@Billlynch Billlynch requested a review from a team August 16, 2020 13:18
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 16, 2020
@Billlynch Billlynch changed the title r/iot_authroizer - new resource [WIP] r/iot_authroizer - new resource Aug 16, 2020
@Billlynch Billlynch changed the title [WIP] r/iot_authroizer - new resource r/iot_authroizer - new resource Aug 16, 2020
@teamterraform
Copy link

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

@Billlynch Billlynch changed the title r/iot_authroizer - new resource r/iot_authorizer - new resource Sep 11, 2020
@ballwood
Copy link

ballwood commented Oct 1, 2020

@bflad any timescales on review of this? quite a lot of +1’s now

@erumble erumble mentioned this pull request Oct 12, 2020
Merged
@vhbfernandes
Copy link

@bflad anyone looking at this?

Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2021
ewbankkit
ewbankkit approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSIoTAuthorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTAuthorizer_ -timeout 180m
=== RUN   TestAccAWSIoTAuthorizer_basic
=== PAUSE TestAccAWSIoTAuthorizer_basic
=== RUN   TestAccAWSIoTAuthorizer_disappears
=== PAUSE TestAccAWSIoTAuthorizer_disappears
=== RUN   TestAccAWSIoTAuthorizer_SigningDisabled
=== PAUSE TestAccAWSIoTAuthorizer_SigningDisabled
=== RUN   TestAccAWSIoTAuthorizer_Update
=== PAUSE TestAccAWSIoTAuthorizer_Update
=== CONT  TestAccAWSIoTAuthorizer_basic
=== CONT  TestAccAWSIoTAuthorizer_Update
=== CONT  TestAccAWSIoTAuthorizer_SigningDisabled
=== CONT  TestAccAWSIoTAuthorizer_disappears
--- PASS: TestAccAWSIoTAuthorizer_disappears (40.49s)
--- PASS: TestAccAWSIoTAuthorizer_Update (45.84s)
--- PASS: TestAccAWSIoTAuthorizer_basic (49.35s)
--- PASS: TestAccAWSIoTAuthorizer_SigningDisabled (54.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.722s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSIoTAuthorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTAuthorizer_ -timeout 180m
=== RUN   TestAccAWSIoTAuthorizer_basic
=== PAUSE TestAccAWSIoTAuthorizer_basic
=== RUN   TestAccAWSIoTAuthorizer_disappears
=== PAUSE TestAccAWSIoTAuthorizer_disappears
=== RUN   TestAccAWSIoTAuthorizer_SigningDisabled
=== PAUSE TestAccAWSIoTAuthorizer_SigningDisabled
=== RUN   TestAccAWSIoTAuthorizer_Update
=== PAUSE TestAccAWSIoTAuthorizer_Update
=== CONT  TestAccAWSIoTAuthorizer_basic
=== CONT  TestAccAWSIoTAuthorizer_Update
=== CONT  TestAccAWSIoTAuthorizer_SigningDisabled
=== CONT  TestAccAWSIoTAuthorizer_disappears
--- PASS: TestAccAWSIoTAuthorizer_basic (37.34s)
--- PASS: TestAccAWSIoTAuthorizer_disappears (41.32s)
--- PASS: TestAccAWSIoTAuthorizer_SigningDisabled (56.25s)
--- PASS: TestAccAWSIoTAuthorizer_Update (62.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.121s

@ewbankkit
Copy link
Contributor

@Billlynch Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 18a8835 into hashicorp:main Sep 28, 2021
@github-actions github-actions bot added this to the v3.61.0 milestone Sep 28, 2021
ewbankkit added a commit that referenced this pull request Sep 28, 2021
@ewbankkit
Add missing CHANGELOG entry for #14671.
92fb6bd
@ewbankkit ewbankkit mentioned this pull request Sep 28, 2021
Merged
ewbankkit added a commit that referenced this pull request Sep 28, 2021
@ewbankkit
Merge pull request #21071 from hashicorp/td-missing-changelog-entry-1…
eb2227f 
…4671

Add missing CHANGELOG entry for #14671
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/iot Issues and PRs that pertain to the iot service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.61.0
Development

Successfully merging this pull request may close these issues.

Support AWS IoT Core Custom Authorizers
6 participants
@Billlynch @teamterraform @ballwood @vhbfernandes @ewbankkit @breathingdust